Conditions | 4 |
Total Lines | 57 |
Code Lines | 45 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | import { Inject } from '@nestjs/common'; |
||
23 | |||
24 | public async execute(command: CreateNotificationCommand): Promise<string> { |
||
25 | const { message, type, leaveReaquest } = command; |
||
26 | |||
27 | if (type === NotificationType.POST) { |
||
28 | const { id } = await this.mattermostNotifier.createPost( |
||
29 | MATTERMOST_CHANNEL_LEAVES_ID, |
||
30 | message |
||
31 | ); |
||
32 | const notification = await this.notificationRepository.save( |
||
33 | new Notification(type, message, id, leaveReaquest) |
||
34 | ); |
||
35 | |||
36 | return notification.getId(); |
||
37 | } |
||
38 | |||
39 | if (type === NotificationType.REACTION) { |
||
40 | const rootNotification = await this.getRootNotification( |
||
41 | leaveReaquest.getId() |
||
42 | ); |
||
43 | |||
44 | await this.mattermostNotifier.createReaction( |
||
45 | rootNotification.getResourceId(), |
||
46 | message |
||
47 | ); |
||
48 | |||
49 | const notification = await this.notificationRepository.save( |
||
50 | new Notification( |
||
51 | type, |
||
52 | message, |
||
53 | rootNotification.getResourceId(), |
||
54 | leaveReaquest |
||
55 | ) |
||
56 | ); |
||
57 | |||
58 | return notification.getId(); |
||
59 | } |
||
60 | |||
61 | if (type === NotificationType.COMMENT) { |
||
62 | const rootNotification = await this.getRootNotification( |
||
63 | leaveReaquest.getId() |
||
64 | ); |
||
65 | |||
66 | const { id } = await this.mattermostNotifier.createComment( |
||
67 | this.configService.get<string>('MATTERMOST_CHANNEL_LEAVES_ID'), |
||
68 | message, |
||
69 | rootNotification.getResourceId() |
||
70 | ); |
||
71 | |||
72 | const notification = await this.notificationRepository.save( |
||
73 | new Notification(type, message, id, leaveReaquest) |
||
74 | ); |
||
75 | |||
76 | return notification.getId(); |
||
77 | } |
||
78 | |||
79 | throw new Error('Type not managed'); |
||
80 | } |
||
89 |